chore (website): add deployed examples to demos on website #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thruflo
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Great, thanks for doing this 👍
Just one thing is that I notice you’ve added demo: true and homepage: true to all of them.
The idea is that demo: true distinguishes interesting visual demos from technical examples. Just because it’s deployed doesn’t mean it should be a “demo”.
And for the homepage we should only have our three most interesting demos featured.
|
Ok, wasn't sure about that. Will fix that |
kevin-dp
force-pushed
the
kevin/add-deployed-examples-to-website
branch
from
b467b78 to
471a1e9
Compare
thruflo
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds all of the deployed examples as demos on the website.